Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve figure size and show argument in viz functions #158

Merged
merged 9 commits into from
Feb 14, 2024

Conversation

mscheltienne
Copy link
Collaborator

@mscheltienne mscheltienne commented Feb 14, 2024

Closes #97
Closes #126

Try to define a better figsize for cluster center plots.
Move the show argument outsides of the kwargs of the viz functions to make it explicit.
Fix ruff configuration which now requires separate tools.ruff.lint and tools.ruff.format section.
Enable ruff lint rules A and B.

@mscheltienne
Copy link
Collaborator Author

Screenshot from 2024-02-14 14-45-38

Figsize looks better.
@vferat merge if happy. Also, OK to cut a new release with the recent additions?

@vferat
Copy link
Owner

vferat commented Feb 14, 2024

Renders are way better this way ! Thanks

Any reason not to include show = plt.isinteractive() if show is None else show in a _check_show function ?

def _check_show(show):
    """Check show parameter."""
    _check_type(show, (bool, None), "show")
    show = plt.isinteractive() if show is None else show
    return show

@mscheltienne
Copy link
Collaborator Author

Done as _ensure_valid_show, I renamed the function because I make the difference between:

  • _check_xxx which returns None
  • _ensure_xxx which returns a validated object of xxx

@vferat
Copy link
Owner

vferat commented Feb 14, 2024

Perfect !
LGTM, and I agree that a release could be nice, a minor version 0.4.2 maybe ?

@mscheltienne
Copy link
Collaborator Author

I would say 0.5.0
Nomenclature is major.minor.bugfix and I would not consider the new features as part of a bug fix release ;)

@mscheltienne mscheltienne merged commit 65e198a into vferat:main Feb 14, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants